Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop base64 gem from dependency #810

Merged
merged 1 commit into from
Oct 1, 2024
Merged

Conversation

tricknotes
Copy link
Contributor

@tricknotes tricknotes commented Sep 21, 2024

This following warning is shown in test.

/Users/ryunosuke.sato/src/github.com/rails/sprockets/lib/sprockets/mime.rb:2: warning: base64 was loaded from the standard library, but will no longer be part of the default gems starting from Ruby 3.4.0.
You can add base64 to your Gemfile or gemspec to silence this warning.

Instead of adding base64 to dependency, the usage of Base64#strict_encode64 and Base64#encode64 have replaced with Array#pack.

Also, this PR fixes CI for Ruby 3.4-dev.

Note: Similar PRs are here

@tricknotes

This comment was marked as outdated.

This following warning is shown in test.
```
/Users/ryunosuke.sato/src/github.com/rails/sprockets/lib/sprockets/mime.rb:2: warning: base64 was loaded from the standard library, but will no longer be part of the default gems starting from Ruby 3.4.0.
You can add base64 to your Gemfile or gemspec to silence this warning.
```

Instead of adding base64 to dependency, the usage of `Base64#strict_encode64` and `Base64#encode64` have replaced with `Array#pack`.
@tricknotes
Copy link
Contributor Author

@byroot
Could you review this PR?

@byroot byroot merged commit e4686d5 into rails:main Oct 1, 2024
14 checks passed
@tricknotes tricknotes deleted the drop-base64 branch October 1, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants